Quick fixes for getting amdci1 up and running #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After mounting the overlay in our `overlay_probe` executable, attempt to `rename()` a directory. This should fail with `EXDEV` if our upper does not allow setting the appropriate extended attributes, as documented here [0]. The solution is to try without `userxattr` applied, as well as trying different mount points. [0] https://docs.kernel.org/filesystems/overlayfs.html#renaming-directories
We started using `realpath()` to collapse down symlinks so that if our mappings were actually on a different underlying mountpoint than they initially appeared, we could warn the user at `SandboxConfig` construction time. Now let's just resolve what we can, and rely on the user to not do something silly like create a symlink to someplace else _after_ we've already constructed the `SandboxConfig` object.
Everyone should always use `with_executor()` so that `cleanup(exe)` is automatically called for you!
staticfloat
force-pushed
the
sf/quick_fixes
branch
from
a0c2ef2 to
2fbdbf7
Compare
This is necessary to properly test unprivileged user namspaces on buildkite. It also allows us to drop the installation of GCC!
staticfloat
force-pushed
the
sf/quick_fixes
branch
from
2fbdbf7 to
b29dfc0
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 78.70% 78.78% +0.07%
==========================================
Files 6 6
Lines 620 627 +7
==========================================
+ Hits 488 494 +6
- Misses 132 133 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.