Use Tar_jll.jl to provide a GNU tar binary (instead of relying on the system tar) #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does |
|
🤔 In theory, you can use the Docker executor on Windows? |
giordano
reviewed
Aug 13, 2021
giordano
reviewed
Aug 13, 2021
giordano
reviewed
Aug 13, 2021
|
I'm going to build a new |
|
Now it should be working |
Codecov Report
@@ Coverage Diff @@
## main #51 +/- ##
==========================================
- Coverage 79.01% 79.00% -0.01%
==========================================
Files 6 6
Lines 529 524 -5
==========================================
- Hits 418 414 -4
+ Misses 111 110 -1
Continue to review full report at Codecov.
|
|
Error during initialization of module |
|
It doesn't make sense it fails in 2 out of 6 jobs |
|
Maybe network issues, resulting in incomplete downloads that fail the subsequent hash check? |
|
What is going on here |
|
Bad things it seems. |
|
So it seems like the problem is when trying to instantiate the package environment inside of a Docker sandbox. |
|
In JuliaPackaging/Yggdrasil#3499 I added |
|
Huh. Yeah, maybe try removing that dependency, just to see if it fixes things? I also don't understand why that would be the problem, but 🤷 |
|
That'd be tomorrow though 💤 |
|
Actually, I take that back. It does look like the error is ultimately coming from |
|
Can you reproduce locally? |
Yes, thankfully. I ran the tests on an Linux x86_64 machine on which Docker is installed and on which I have Here is the log of the tests failing locally. The log looks basically the same as the CI logs. Click to expand: |
|
Try Tar_jll 1.32 |
|
Yeah, if I set a compat entry of the form I left that code there (commented out), so that we can switch to it easily in the future. |
|
CI is green if I restrict Tar_jll to |
|
@staticfloat What do you think about merging this as-is, and then in the future we can upgrade to a new version of Tar_jll that supports I don't think there's a particular rush on upgrading the Tar_jll version. |
Closed
… system tar) Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
|
@staticfloat @giordano What are your thoughts on this PR? My preference would be to merge this PR now as-is, and then update to the newest Tar_jll after we can solve the bug with loading libraries on musl. |
staticfloat
approved these changes
Aug 19, 2021
|
Thanks @staticfloat! Can we also get a new release of Sandbox.jl? |
This was referenced Jan 28, 2022
giordano
added a commit
to JuliaRegistries/General
that referenced
this pull request
Jan 28, 2022
For context, see all the issues we had because of `acl_jll` in JuliaContainerization/Sandbox.jl#51
JuliaTagBot
pushed a commit
to JuliaRegistries/General
that referenced
this pull request
Jan 29, 2022
* New version: Tar_jll v1.34.0+1 UUID: 9b64493d-8859-5bf3-93d7-7c32dd38186f Repo: https://github.com/JuliaBinaryWrappers/Tar_jll.jl.git Tree: f563224757d6c7bddf393435e96504259a517337 Registrator tree SHA: 8e1a5ac2695627143951512d700c7e3c445102ec * [Tar_jll] Yank `1.34.0+0` and remove dependency on `acl_jll` For context, see all the issues we had because of `acl_jll` in JuliaContainerization/Sandbox.jl#51 Co-authored-by: Mosè Giordano <mose@gnu.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some systems (e.g. macOS) ship by default with a BSD
tarthat does not support the--ownerand--groupcommand-line options.This PR adds Tar_jll.jl as a dependency and uses it to provide a GNU
tarso that we do not have to rely on the systemtar.If Tar_jll is not supported on the platform, we fall back to the system
tar.