Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When registering binfmt_misc entries, print an @info message about sudo even if verbose is false #59

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

DilumAluthge
Copy link
Member

Users will probably wonder why they are being asked for their sudo password (especially if they want to use the unprivileged user namespaces executor), so we should always show the @info message explaining why, even if verbose is false.

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #59 (40cd021) into main (51bf7f4) will increase coverage by 0.07%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   79.01%   79.09%   +0.07%     
==========================================
  Files           6        6              
  Lines         529      531       +2     
==========================================
+ Hits          418      420       +2     
  Misses        111      111              
Impacted Files Coverage Δ
src/binfmt_misc.jl 80.19% <60.00%> (+0.60%) ⬆️
src/Sandbox.jl 73.21% <0.00%> (-0.47%) ⬇️
src/Docker.jl 85.03% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51bf7f4...40cd021. Read the comment docs.

@staticfloat
Copy link
Collaborator

Maybe instead we can test to see if sudo is going to ask for a password, and print the message only if we think it will? Testing if !success(sudo -k -n true) should tell us if sudo is going to require a password.

@DilumAluthge
Copy link
Member Author

Done!

@staticfloat staticfloat merged commit 58b1d87 into JuliaContainerization:main Aug 23, 2021
@DilumAluthge DilumAluthge deleted the dpa/info-before-sudo branch August 23, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants