Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostname option to SandboxConfig #65

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Add hostname option to SandboxConfig #65

merged 2 commits into from
Jan 6, 2022

Conversation

staticfloat
Copy link
Collaborator

@staticfloat staticfloat commented Nov 22, 2021

This allows us to launch sandboxes with a deterministic hostname, if we so desire to. Useful for things like fully reproducible builds, etc...

Closes #64

This allows us to launch sandboxes with a deterministic hostname, if we
so desire to.  Useful for things like fully reproducible builds, etc...
@staticfloat staticfloat merged commit 9bd66da into main Jan 6, 2022
@giordano
Copy link
Member

giordano commented Jan 6, 2022

Test were failing 🤔

@staticfloat
Copy link
Collaborator Author

staticfloat commented Jan 6, 2022

The local builds work, the ones that use the JLL were failing, that's expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not leak information from the host system
2 participants