Use @static check to simplify get_loaded_modules
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #80 +/- ##
==========================================
+ Coverage 79.12% 79.57% +0.45%
==========================================
Files 6 6
Lines 570 568 -2
==========================================
+ Hits 451 452 +1
+ Misses 119 116 -3
Continue to review full report at Codecov.
|
|
Incidentally, the static check makes the function type-stable because we return |
staticfloat
reviewed
Jan 29, 2022
giordano
force-pushed
the
mg/get-loaded-modules
branch
2 times, most recently
from
b4a7aa0 to
5e22632
Compare
staticfloat
approved these changes
Jan 29, 2022
|
Bump 🙂 |
giordano
force-pushed
the
mg/get-loaded-modules
branch
from
5e22632 to
d077ba2
Compare
staticfloat
reviewed
Mar 16, 2022
| return Vector{String}[] | ||
| end | ||
|
|
||
| !isfile("/proc/modules") && return Vector{SubString{String}}[] |
There was a problem hiding this comment.
It looks like one path returns Vector{String}[] and the other returns Vector{SubString{String}}[]. I think we can just safely return Vector{String}[] in both cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.