Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated usage of functions in feacalc #34

Closed
wheeheee opened this issue Oct 19, 2023 · 3 comments · Fixed by #35
Closed

Fix deprecated usage of functions in feacalc #34

wheeheee opened this issue Oct 19, 2023 · 3 comments · Fixed by #35

Comments

@wheeheee
Copy link
Member

Right now feacalc throws an error, which I traced to

  • 2 instances of sum omitting the dims keyword argument
  • one is in sad, the other is basically a copy of it, maybe sad can be called instead?
  • Plus the log10 looks like it is supposed to be broadcasted
  • Float64 should replace float64
  • Indexing in sad looks old and doesn't work now but I still get BoundsErrors even after updating that.
  • The readall in soxread should also be changed, and maybe also use an open do block?
@davidavdav
Copy link
Collaborator

Yes it looks like this code hasn't been used in many versions of Julia, incl version 1.

Since you already put some effort in this, any chance you can fix this and submit a PR?

@wheeheee
Copy link
Member Author

I've submitted one, can you review?

@davidavdav
Copy link
Collaborator

Yes, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants