Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to outdated language #35

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Fixes to outdated language #35

merged 2 commits into from
Oct 23, 2023

Conversation

wheeheee
Copy link
Member

Resolves #34 and does some other things

removed many unnecessary collects
changed to broadcasting
conj!(x) works fine, removed the workaround.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6598699037

  • 81 of 171 (47.37%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.8%) to 43.713%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/mfccs.jl 26 40 65.0%
src/io.jl 3 19 15.79%
src/rasta.jl 38 64 59.38%
src/feacalc.jl 14 48 29.17%
Files with Coverage Reduction New Missed Lines %
src/mfccs.jl 1 59.5%
src/rasta.jl 2 47.0%
Totals Coverage Status
Change from base Build 6447296086: 0.8%
Covered Lines: 219
Relevant Lines: 501

💛 - Coveralls

@davidavdav davidavdav merged commit a4b94ee into JuliaDSP:main Oct 23, 2023
7 checks passed
@davidavdav
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix deprecated usage of functions in feacalc
3 participants