Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and better loops #36

Merged
merged 15 commits into from
Oct 29, 2023
Merged

Fixes and better loops #36

merged 15 commits into from
Oct 29, 2023

Conversation

wheeheee
Copy link
Member

  • redundant exp log?
  • fixed some typos
  • throw named errors
  • loops run faster
  • some memoization?

wheeheee added 15 commits October 23, 2023 09:55
@wheeheee
named exceptions, cosmetic changes
a00d765 
also changed hz2mel to accept floats instead of vectors
@wheeheee
more fixes, small improvements
74cd698 
broadcasting, named errors
@wheeheee
stmvn + cosmetics
b60bc62 
generalize for AbstractVector
@wheeheee
bump hdf5 and use symbols in dict
e20fe5f 
- isdefined macro
- removed HDF5.write for Bool and SubString
@wheeheee
AbstractVector indexing, better toeplitz
d55ee8b 
changed current toeplitz impl to accept same arguments, produce the same output as in current octave documentation.
prev usage in levinson was dubious?
@wheeheee
reduce allocs for delta, abstractvector stuff
238c375
@wheeheee
improve lpc2cep loop + cosmetics
5f6aca1
@wheeheee
fixed lpc2cep
3848fdd
@wheeheee
go back to using vector for lpc2cep
fa95b04
@wheeheee
exp10, remove exp(log(*))
64df2f9
@wheeheee
small fixes and cosmetics
0b1a496
@wheeheee
bump version?
2ad4ede
@wheeheee
actually throw errors, memoize weights
8371767
@wheeheee
memoize dct_matrix
899e525
@wheeheee
remove exp log
971f373
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6676470376

  • 96 of 201 (47.76%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+10.7%) to 54.435%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feacalc.jl 23 32 71.88%
src/mfccs.jl 29 57 50.88%
src/rasta.jl 37 105 35.24%
Files with Coverage Reduction New Missed Lines %
src/feacalc.jl 1 45.61%
src/mfccs.jl 1 58.62%
src/rasta.jl 1 49.1%
Totals Coverage Status
Change from base Build 6610274851: 10.7%
Covered Lines: 270
Relevant Lines: 496
💛 - Coveralls

@davidavdav
Copy link
Collaborator

Thanks, I went through the diffs (in reverse order), and it looks like a pretty thorough re-write!

@davidavdav davidavdav merged commit b9808f9 into JuliaDSP:main Oct 29, 2023
7 checks passed
@wheeheee
Copy link
Member Author

Actually I was a little confused by the code in deltas so do you mind confirming that it keeps only rows 2hlen+1 onwards?
Since you've padded hlen rows in front and behind, I thought the middle would be kept after filt, but I don't really get what filt does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wheeheee @coveralls @davidavdav