Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV v0.9.6 fails to precompile as solo package on fresh 1.6.1 project on Ubuntu #927

Closed
layne-sadler opened this issue Oct 7, 2021 · 6 comments

Comments

@layne-sadler
Copy link

Note the ✗ WeakRefStrings.

(v1.6) pkg> generate LayneProject
  Generating  project LayneProject:
    LayneProject/Project.toml
    LayneProject/src/LayneProject.jl

(v1.6) pkg> activate LayneProject
  Activating environment at `/mnt/data/code/LayneProject/Project.toml`

(LayneProject) pkg> add CSV
   Resolving package versions...
    Updating `/mnt/data/code/LayneProject/Project.toml`
  [336ed68f] + CSV v0.9.6
    Updating `/mnt/data/code/LayneProject/Manifest.toml`
  [336ed68f] + CSV v0.9.6
  [944b1d66] + CodecZlib v0.7.0
  [9a962f9c] + DataAPI v1.9.0
  [e2d170a0] + DataValueInterfaces v1.0.0
  [48062228] + FilePathsBase v0.9.12
  [842dd82b] + InlineStrings v1.0.1
  [82899510] + IteratorInterfaceExtensions v1.0.0
  [69de0a69] + Parsers v2.0.5
  [2dfb63ee] + PooledArrays v1.3.0
  [91c51154] + SentinelArrays v1.3.7
  [3783bdb8] + TableTraits v1.0.1
  [bd369af6] + Tables v1.6.0
  [3bb67fe8] + TranscodingStreams v0.9.6
  [ea10d353] + WeakRefStrings v1.4.1
  [2a0f44e3] + Base64
  [ade2ca70] + Dates
  [9fa8497b] + Future
  [b77e0a4c] + InteractiveUtils
  [8f399da3] + Libdl
  [37e2e46d] + LinearAlgebra
  [56ddb016] + Logging
  [d6f4376e] + Markdown
  [a63ad114] + Mmap
  [de0858da] + Printf
  [9a3f8284] + Random
  [ea8e919c] + SHA
  [9e88b42a] + Serialization
  [8dfed614] + Test
  [cf7118a7] + UUIDs
  [4ec0a83e] + Unicode
  [83775a58] + Zlib_jll
Precompiling project...
  ✗ WeakRefStrings
  ✗ CSV
  1 dependency successfully precompiled in 5 seconds (13 already precompiled)
  2 dependencies errored. To see a full report either run `import Pkg; Pkg.precompile()` or load the packages

julia> VERSION
v"1.6.1"

shell> cat /etc/os-release
NAME="Ubuntu"
VERSION="20.04.3 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.3 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal
@layne-sadler layne-sadler changed the title CSV v0.9.6 fails to precompile as solo package on fresh 1.6.1 project CSV v0.9.6 fails to precompile as solo package on fresh 1.6.1 project on Ubuntu Oct 7, 2021
@quinnj
Copy link
Member

quinnj commented Oct 7, 2021

This is usually pretty benign and just means the package was already loaded when it goes to precompile or something. If you restart julia fresh for the Project in question, it should work.

@layne-sadler
Copy link
Author

layne-sadler commented Oct 7, 2021

Yeah, my scripts on my local machine work just fine with this. However, it is throwing errors and therefore terminating my remote worker nodes.

stacktrace: "LoadError: LoadError: Failed to precompile CSV [336ed68f-0bac-5ca0-87d4-7b16caf5d00b]

@layne-sadler
Copy link
Author

layne-sadler commented Oct 7, 2021

Downgrading to 0.8.5 removes the WeakRefStrings dependency and it precompiles clean

julia> Pkg.add(name="CSV", version="0.8.5")
   Resolving package versions...
    Updating `/mnt/data/code/LayneProject/Project.toml`
  [336ed68f] ↓ CSV v0.9.0 ⇒ v0.8.5
    Updating `/mnt/data/code/LayneProject/Manifest.toml`
  [336ed68f] ↓ CSV v0.9.0 ⇒ v0.8.5
  [944b1d66] - CodecZlib v0.7.0
  [48062228] - FilePathsBase v0.9.12
  [842dd82b] - InlineStrings v1.0.1
  [69de0a69] ↓ Parsers v2.0.5 ⇒ v1.1.2
  [3bb67fe8] - TranscodingStreams v0.9.6
  [ea10d353] - WeakRefStrings v1.4.1
  [ea8e919c] - SHA
  [cf7118a7] - UUIDs
  [83775a58] - Zlib_jll

julia> pkg> precompile

julia> pkg> pin CSV
   Resolving package versions...
    Updating `/mnt/data/code/LayneProject/Project.toml`
  [336ed68f] ~ CSV v0.8.5 ⇒ v0.8.5 ⚲
    Updating `/mnt/data/code/LayneProject/Manifest.toml`
  [336ed68f] ~ CSV v0.8.5 ⇒ v0.8.5 ⚲

@quinnj
Copy link
Member

quinnj commented Oct 7, 2021

I can't reproduce:

(domo) pkg> up
    Updating registry at `~/.julia/registries/General`
    Updating git-repo `https://github.com/JuliaRegistries/General.git`
   Installed WeakRefStrings ─ v1.4.1
   Installed InlineStrings ── v1.0.1
   Installed Parsers ──────── v2.0.5
   Installed CSV ──────────── v0.9.6
    Updating `~/domo/Project.toml`
  [336ed68f]  CSV v0.8.5  v0.9.6
  [ea10d353]  WeakRefStrings v1.1.0  v1.4.1
    Updating `~/domo/Manifest.toml`
  [336ed68f]  CSV v0.8.5  v0.9.6
  [944b1d66] + CodecZlib v0.7.0
  [48062228] + FilePathsBase v0.9.12
  [842dd82b] + InlineStrings v1.0.1
  [69de0a69]  Parsers v1.1.2  v2.0.5
  [3bb67fe8] + TranscodingStreams v0.9.6
  [ea10d353]  WeakRefStrings v1.1.0  v1.4.1
  [ea8e919c] + SHA
  [cf7118a7] + UUIDs
  [83775a58] + Zlib_jll
Precompiling project...
  4 dependencies successfully precompiled in 10 seconds (14 already precompiled)

(domo) pkg> st
      Status `~/domo/Project.toml`
  [336ed68f] CSV v0.9.6
  [91c51154] SentinelArrays v1.3.7
  [ea10d353] WeakRefStrings v1.4.1

@layne-sadler
Copy link
Author

layne-sadler commented Oct 7, 2021

I can't reproduce

what OS and Julia version?

@quinnj
Copy link
Member

quinnj commented Oct 7, 2021

Oh, you're probably running into JuliaLang/julia#28781?

@quinnj quinnj closed this as completed Oct 19, 2021
nickrobinson251 added a commit to nickrobinson251/CSV.jl that referenced this issue Jan 29, 2022
- Set the value if we have `valueok` rather
  than relying on `!invalid`, to avoid erroring
  when we have successfully parsed a string but
  then hit an invalid delimiter.
- Fixes JuliaData#927.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants