Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multithreaded fail on trailing empty column #1098

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

Liozou
Copy link
Contributor

@Liozou Liozou commented Jun 17, 2023

While looking at #1095 I noticed that multi-threaded parsing currently fails (and falls back to single-thread) when a file ends with a trailing empty column, i.e. a line ending with a column delimiter with no trailing newline. This fixes that.

@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (07fb6c2) 90.40% compared to head (108e2de) 90.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1098      +/-   ##
==========================================
+ Coverage   90.40%   90.43%   +0.02%     
==========================================
  Files           9        9              
  Lines        2294     2299       +5     
==========================================
+ Hits         2074     2079       +5     
  Misses        220      220              
Impacted Files Coverage Δ
src/detection.jl 96.38% <100.00%> (+0.04%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Liozou!

@quinnj quinnj merged commit bbaeec0 into JuliaData:main Jun 20, 2023
@Liozou Liozou deleted the trailingemptycolumn branch July 27, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants