Add isordered for CategoricalValue (#254)

JuliaData · Mar 23, 2020 · 81867f6 · 81867f6
1 parent 92e3114
commit 81867f6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/value.jl b/src/value.jl
@@ -13,6 +13,7 @@ reftype(x::Any) = reftype(typeof(x))
 
 pool(x::CategoricalValue) = x.pool
 level(x::CategoricalValue) = x.level
+isordered(x::CategoricalValue) = isordered(x.pool)
 
 # extract the type of the original value from array eltype `T`
 unwrap_catvaluetype(::Type{T}) where {T} = T
@@ -177,4 +178,4 @@ JSON.lower(x::CategoricalValue) = JSON.lower(get(x))
 DataAPI.defaultarray(::Type{CategoricalValue{T, R}}, N) where {T, R} =
   CategoricalArray{T, N, R}
 DataAPI.defaultarray(::Type{Union{CategoricalValue{T, R}, Missing}}, N) where {T, R} =
-  CategoricalArray{Union{T, Missing}, N, R}
+  CategoricalArray{Union{T, Missing}, N, R}
diff --git a/test/10_isless.jl b/test/10_isless.jl
@@ -9,6 +9,10 @@ v2 = CategoricalValue(2, pool)
 v3 = CategoricalValue(3, pool)
 
 @testset "values from unordered CategoricalPool" begin
+    @test isordered(v1) === false
+    @test isordered(v2) === false
+    @test isordered(v3) === false
+
     @test_throws ArgumentError v1 < v1
     @test_throws ArgumentError v1 < v2
     @test_throws ArgumentError v1 < v3
@@ -98,6 +102,9 @@ end
 @testset "values from ordered CategoricalPool" begin
     @test ordered!(pool, true) === pool
     @test isordered(pool) === true
+    @test isordered(v1) === true
+    @test isordered(v2) === true
+    @test isordered(v3) === true
 
     @test (v1 < v1) === false
     @test (v1 < v2) === true