Fix convert with Union{T, Nothing} #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bkamins
reviewed
Sep 27, 2019
| @@ -87,9 +87,9 @@ Base.convert(::Type{Union{T, Nothing}}, x::T) where {T <: CatValue} = x | |||
| Base.convert(::Type{S}, x::T) where {S, T <: CatValue} = | |||
| T <: S ? x : convert(S, get(x)) | |||
| Base.convert(::Type{Union{S, Missing}}, x::T) where {S, T <: CatValue} = | |||
| T <: S ? x : convert(S, get(x)) | |||
| T <: Union{S, Missing} ? x : convert(Union{S, Missing}, get(x)) | |||
There was a problem hiding this comment.
Are these two definitions for Nothing and Missing needed? It seems that by leaving https://github.com/JuliaData/CategoricalArrays.jl/pull/213/files#diff-0c97238b80ec111debf6823967ed4c9eR87 only (ie. the default convert) we should get exactly the same?
There was a problem hiding this comment.
Yes, that's due to ambiguities with methods defined in Base.
There was a problem hiding this comment.
OK, this is the pain I have with DataFrames.jl every time I do a major redesign of something that touches Base.
There was a problem hiding this comment.
Hopefully with #201 we will be able to simplify this.
bkamins
approved these changes
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
append!problem reported at #172 (comment).