Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC/WIP] More NullableArrays compatibility #29

Closed
wants to merge 3 commits into from

Conversation

alyst
Copy link
Contributor

@alyst alyst commented Oct 4, 2016

Add NullableArrays.jl requirement and implement a few of its methods (including the novel ones proposed by JuliaStats/NullableArrays.jl#155)

  • unsafe_getindex/value_notnull()
  • [unsafe_]isnull()
  • padnull[!]()
  • reftype(A::[Nullable]CategoricalArray) to get the type of the references of A

@nalimilan
Copy link
Member

@DavidGold Do you think padnull! is really needed? Couldn't this be a method of resize!, with an additional before::Bool argument?

@coveralls
Copy link

coveralls commented Mar 9, 2017

Coverage Status

Coverage decreased (-1.4%) to 89.883% when pulling 072a84f on alyst:extend_api into b88769b on JuliaData:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.4%) to 89.883% when pulling 072a84f on alyst:extend_api into b88769b on JuliaData:master.

@codecov-io
Copy link

codecov-io commented Mar 9, 2017

Codecov Report

Merging #29 into master will decrease coverage by 1.19%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #29     +/-   ##
=========================================
- Coverage   92.46%   91.27%   -1.2%     
=========================================
  Files           9        9             
  Lines         690      699      +9     
=========================================
  Hits          638      638             
- Misses         52       61      +9
Impacted Files Coverage Δ
src/nullablearray.jl 62.85% <0%> (-8.12%) ⬇️
src/array.jl 91.83% <25%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15ab16f...fc90a48. Read the comment docs.

@coveralls
Copy link

coveralls commented May 11, 2017

Coverage Status

Coverage decreased (-1.5%) to 90.706% when pulling 070a0a5 on alyst:extend_api into 0b2aa3a on JuliaData:master.

@nalimilan
Copy link
Member

No longer applies now that we've moved to Nulls.

@nalimilan nalimilan closed this Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants