WIP: Adjustments for common Table interface #55
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny one but there might be more changes that I'd like to propose in order to get a common interface for tables that
StatsModels
can use. The change here is consistent with the behavior inNullableArrays
and it might help in the construction of contrasts. I don't think there should be any NullableArrays specific code in StatsModels and the price would then have to be that theContrastsMatrix
hasNullable
s in it but I guess that is in line with the idea of propagating nullables.