Skip to content

Commit

Permalink
Removed test/conversions.jl version check.
Browse files Browse the repository at this point in the history
  • Loading branch information
rofinn authored and quinnj committed Sep 2, 2017
1 parent 8a5f0ca commit 55ecb4c
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions test/conversions.jl
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,8 @@ module TestConversions
df = DataFrame()
df[:A] = 1:5
df[:B] = 1.0:5.0
# Fails on Julia 0.4 since promote_type(Nullable{Int}, Nullable{Float64}) gives Nullable{T}
if VERSION >= v"0.5.0-dev"
@test isa(convert(Array, df), Matrix{Float64})
end
@test isa(convert(Array, df), Matrix{Float64})

@test convert(Array, df) == convert(Array, convert(NullableArray, df))
@test isa(convert(Array{Any}, df), Matrix{Any})
@test isa(convert(Array{Float64}, df), Matrix{Float64})
Expand Down

0 comments on commit 55ecb4c

Please sign in to comment.