Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Sparse ModelMatrix support #1040

Merged
merged 11 commits into from
Aug 26, 2016
Merged

RFC: Sparse ModelMatrix support #1040

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c61a0ec
Parametrize ModelMatrix container type
Aug 20, 2016
d46fc37
Eliminate hardcoded model matrix container type when constructing fro…
Aug 20, 2016
288552c
More idiomatic model matrix constructor and relaxed container type re…
Aug 21, 2016
e1b068e
Generalize modelmat_cols output typing
Aug 21, 2016
4a9a65f
Generalize expandcols output types
Aug 21, 2016
fd12a5d
Added sparse ModelMatrix creation tests
Aug 21, 2016
ff6f706
More explicit model matrix constructor type output testing
Aug 21, 2016
f94dd83
Rename ModelMatrixContainer and remove unneeded variables/methods
Aug 21, 2016
dd0ae91
Split value assignment onto two lines
Aug 22, 2016
db58318
Fix test result spacing and incorrect method signature documentation
Aug 22, 2016
25935c0
Docstring updates
Aug 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/statsmodels/formula.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,12 +374,11 @@ end
expandcols(trm::Vector)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This signature should also be updated to mention the restriction on the element type.

Create pairwise products of columns from a vector of matrices
"""
function expandcols(trm::Vector)
function expandcols{T<:ModelMatrixContainer}(trm::Vector{T})
if length(trm) == 1
asmatrix(Matrix{Float64}, convert(Array{Float64}, trm[1]))
trm[1]
else
a = convert(Array{Float64}, trm[1])
b = expandcols(trm[2 : end])
a, b = trm[1], expandcols(trm[2 : end])
Copy link
Author

@GordStephen GordStephen Aug 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, the conversions here (and just above) are redundant since elements of trm are always created by modelmat_cols, which already handles this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the assignments on two lines.

reduce(hcat, [broadcast(*, a, Compat.view(b, :, j)) for j in 1 : size(b, 2)])
end
end
Expand Down