Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up test files #1691

Merged
merged 3 commits into from
Jan 22, 2019
Merged

Clean up test files #1691

merged 3 commits into from
Jan 22, 2019

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Jan 21, 2019

In this PR I fix the indentation in test files to follow standard Julia recommendations.
That is: I removed indentation of code inside module clause.
The reason is that:

  1. sometimes we did it and sometimes we did not do it
  2. these 4 spaces sometimes matter for longer expressions when I want to avoid wrapping

@nalimilan I would also remove files test/stdin.sh and test/data/iris.csv as I think they are not used anywhere (but I might have missed something).

@bkamins bkamins closed this Jan 21, 2019
@bkamins bkamins reopened this Jan 21, 2019
@nalimilan
Copy link
Member

Feel free to remove said files.

@bkamins bkamins merged commit 4e81179 into JuliaData:master Jan 22, 2019
@bkamins
Copy link
Member Author

bkamins commented Jan 22, 2019

Squashed. This will require all open PRs to be rebased, but it was uavoidable and rebasing should be simple.

@bkamins bkamins deleted the code_layout branch January 22, 2019 21:24
This was referenced Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants