Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor change in vcat implementation #1793

Merged
merged 1 commit into from
May 1, 2019
Merged

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Apr 29, 2019

Changes in this PR:

  • make reduce(vcat, dfs; cols) behave in the same way as vcat(dfs...; cols) (this means: disregard data frames with 0 columns and acccept cols keyword argument)
  • make reduce(vcat, dfs; cols) also accept a tuple of AbstractDataFrames and not only an AbstractVector of them

@bkamins
Copy link
Member Author

bkamins commented Apr 29, 2019

Thank you. This PR can wait till the next release, but if we need to do 0.18.2 I would include it, as in my opinion it is a patch making sure vcat and `reduce(vcat,...) are working consistently (as they should).

@nalimilan
Copy link
Member

As you like.

@pdeffebach
Copy link
Contributor

Yeah thanks for this! I didn't know it was allowed to add a keyword argument when dispatching reduce on a function.

@bkamins
Copy link
Member Author

bkamins commented Apr 29, 2019

Actually the issue of dispatch with kwargs is quite tricky (I recently had another issue in DataFrames.jl related to this; here is a status of a long unresolved issue that should improve dispatch rules of functions taking kwargs JuliaLang/julia#9498) but in this case it should be safe.

@bkamins bkamins merged commit 8a20e50 into JuliaData:master May 1, 2019
@bkamins bkamins deleted the vcat_reduced branch May 1, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants