Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First proposal of consistency checks #1887

Merged
merged 3 commits into from
Jul 25, 2019

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Jul 18, 2019

This fixes #1885 and #1845.

What it does:

  • sanitizes push! and append!, as I concluded that it is best to do more strict checks there (as we do dynamic dispatch there anyway)
  • adds consistency checks to join, groupby and _show

(this also lead to a bit different approach to error throwing)

Consistency check for 10000 column costs ~200 microseconds so I think it is acceptable. But please comment on this.

Also please comment where else you think it is worth to add consistency checks.

@nalimilan nalimilan changed the title Fist proposal of consistency checks First proposal of consistency checks Jul 22, 2019
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Though that won't make append! catch problems similar to #1885 but when appending a third data frame: in that case we have no idea that x2 has been corrupt until show is called. But at least that makes the error more visible.

src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
src/dataframe/dataframe.jl Show resolved Hide resolved
src/dataframe/dataframe.jl Show resolved Hide resolved
src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
src/dataframe/dataframe.jl Show resolved Hide resolved
src/dataframe/dataframe.jl Show resolved Hide resolved
src/dataframe/dataframe.jl Show resolved Hide resolved
src/dataframe/dataframe.jl Show resolved Hide resolved
src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
src/dataframe/dataframe.jl Show resolved Hide resolved
src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
@bkamins bkamins merged commit 9f43191 into JuliaData:master Jul 25, 2019
@bkamins bkamins deleted the col_length_check branch July 25, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preventing problems with aliased columns
2 participants