-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First proposal of consistency checks #1887
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
changed the title
Fist proposal of consistency checks
First proposal of consistency checks
Jul 22, 2019
nalimilan
reviewed
Jul 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Though that won't make append!
catch problems similar to #1885 but when appending a third data frame: in that case we have no idea that x2
has been corrupt until show
is called. But at least that makes the error more visible.
This was referenced Jul 25, 2019
nalimilan
reviewed
Jul 25, 2019
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
nalimilan
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1885 and #1845.
What it does:
push!
andappend!
, as I concluded that it is best to do more strict checks there (as we do dynamic dispatch there anyway)join
,groupby
and_show
(this also lead to a bit different approach to error throwing)
Consistency check for 10000 column costs ~200 microseconds so I think it is acceptable. But please comment on this.
Also please comment where else you think it is worth to add consistency checks.