[BREAKING] add empty and empty! #2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should not be merged before #2237 (I would like to have documentation cleaned up, and then I will rebase it) |
This was referenced May 17, 2020
|
@nalimilan - I have reverted the things that are not problematic to keep as deprecated. Now I remove only definitions that are really bad IMO and should not exist even as deprecations. |
nalimilan
reviewed
May 18, 2020
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
nalimilan
approved these changes
May 18, 2020
|
Thank you! |
|
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2251, #2261
@nalimilan - I think what @Nosferican proposed in #2251 can be implemented before 1.0. At the same time I propose to remove rarely used and long-deprecated functions from src/deprecated.jl, this will resolve #2261 in particular.