Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added makeunique argument for Table -> DataFrame #2278

Closed
wants to merge 1 commit into from
Closed

Added makeunique argument for Table -> DataFrame #2278

wants to merge 1 commit into from

Conversation

bosonbaas
Copy link

This is a simple edit which adds the makeunique option for the DataFrame constructor from Table objects.
This PR applies the makeunique functionality introduced in #1333 to the constructor from Tables.

@bosonbaas
Copy link
Author

I have now found that this PR will fail because Table objects are iterated through by name, so while column names will be unique, columns which originally had the same name will all resolve to the first column of that name.

@bosonbaas bosonbaas closed this Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bosonbaas