Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to pass a reference to where to add a column by its name #2365

Merged
merged 8 commits into from
Aug 21, 2020
Merged

allow to pass a reference to where to add a column by its name #2365

merged 8 commits into from
Aug 21, 2020

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Aug 12, 2020

Fixes #2364

@bkamins bkamins added feature non-breaking The proposed change is not breaking labels Aug 12, 2020
@bkamins bkamins added this to the 1.0 milestone Aug 12, 2020
@bkamins bkamins mentioned this pull request Aug 12, 2020
Closed
bkamins
bkamins commented Aug 12, 2020
View reviewed changes
src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
oxinabox
oxinabox approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment but basically LGTM

@nalimilan
Copy link
Member

Good catch. Though we don't use ref to refer to a column selector anywhere else AFAIK -- we rather say col or cols. How about using something like prevcol, colbefore, etc.?

@bkamins
Copy link
Member Author

bkamins commented Aug 19, 2020

OK - I have changed ref to col and col to val.
Also NEWS.md is updated.

@bkamins bkamins merged commit c8ce235 into JuliaData:master Aug 21, 2020
@bkamins bkamins deleted the improve_insertcols branch August 21, 2020 14:45
@bkamins
Copy link
Member Author

bkamins commented Aug 21, 2020

Thank you!

@JuliaRegistrator JuliaRegistrator mentioned this pull request Nov 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxinabox oxinabox oxinabox approved these changes

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
feature non-breaking The proposed change is not breaking
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

insertcols! taking name of column to insert before
3 participants
@bkamins @nalimilan @oxinabox