Adding support for rich display of Markdown cells in HTML and LaTeX output (redux) #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing Markdown as "text/csv" and "text/plain" Fix test error in Markdown to HTML in 32-bit systems Fixing show and adding multi-codepoint tests 32 it is... Use chomp to remove trailing '\n Co-authored-by: Bogumił Kamiński <bkamins@sgh.waw.pl> Fixing conflicts Pulling df[i,j] out and optimizing ourshow. Formatting improvements Additional formatting improvements Fixing triple-quoted strings in 1.0.X Strip space in test case Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr> Using @nalimilan suggestion Improving LaTeX output appearance, NEWS.md entry Moved NEWS.md item to "Other relevant changes" section. Correct NEWS.md item on rich display support
Fixing Markdown as "text/csv" and "text/plain" Fix test error in Markdown to HTML in 32-bit systems Fixing show and adding multi-codepoint tests 32 it is... Use chomp to remove trailing '\n Co-authored-by: Bogumił Kamiński <bkamins@sgh.waw.pl> Fixing conflicts Pulling df[i,j] out and optimizing ourshow. Formatting improvements Additional formatting improvements Fixing triple-quoted strings in 1.0.X Strip space in test case Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr> Using @nalimilan suggestion Improving LaTeX output appearance, NEWS.md entry Moved NEWS.md item to "Other relevant changes" section. Correct NEWS.md item on rich display support Removing duplicate import
|
@bkamins I hope this works for you. I've closed the previous PR. This whole process has been a learning experience for me. Hopefully, in the future, I'll be able to handle future PRs more gracefully. But I am grateful for you patience and I hope these small changes will be of use to DataFrame users. |
bkamins
reviewed
Aug 28, 2020
|
Thank you! I have left one small comment. Looks good other than that. |
nalimilan
reviewed
Aug 29, 2020
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
nalimilan
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
Thanks @NicholasWMRitchie! I'm not sure why the Pkg.add change is visible here since it's also on master, but it should disappear when merging.
|
I will check if all is OK after the merge |
|
Thank you! |
|
All looks good after merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a fairly small change to the HTML, LaTeX and text display code, it is possible to add rich text output support to cells within a DataFrame. Markdown strings are readily constructed using the default Markdown package and the @md_str macro. It already represents a generalized format definition language that most Julia users are familiar with.
It is already possible to place Markdown.MD cells in DataFrames. However, the display of these cells doesn't represent the richness of which Markdown is capable. With markdown, it is possible to output bold, italicized, headers, links and even images into DataFrame cell outputs.
For me personally, the biggest win is the ability to display functional URLs in a table. This is particularly useful when DataFrames are used in report-type documents like generated by Weave or other literate programming packages. I don't think there is another way to produce functional URL links in DataFrame outputs and this is often useful to detail the provenance of the data in a particular row.
However, other people may find being able to place LaTeX formulae or images in cells even more useful.