-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Type to names as cols #2400
Conversation
Thanks, looks good. I still think it would be nice to support this everywhere, but indeed it will require a deeper refactoring. Could you update the |
I updated |
This is great! Love that we have |
Now the deprecation of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's nice that the deprecation is reasonable. That also means many similar operations are now quite easy to do.
Thank you! |
Fixes #2395
Now I understand why I have not added it in the past -
AbstractIndex
is not aware of column types.Therefore I propose to add this option to
names
only. This is useful on its own right. In other places one will have to write something likedf[:, names(df, Int)]
which is a bit verbose, but not that bad. The benefits are twofold:MultiColumnIndex
, as we cannot just extendMultiColumnIndex
withType
)