-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow passing empty sets of columns to ByRow and filter #2476
Conversation
Fixes #2457 |
This is a change before a final |
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
@nalimilan - last two commits are attempts to improve code and compilation latency (hopefully not sacrificing performance for large tables) @pdeffebach - some benchmarking would be welcome (following the discussion on Slack) |
This is what I have now. I think it is good enough for now. I will merge this PR once the tests pass (I have extracted one common case to a separate function and added After this PR:
Before this PR:
release 0.21 (does not support last two operations):
|
Thank you! |
No description provided.