-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark outdated docs #2760
Mark outdated docs #2760
Conversation
Thank you. This PR is impossible to review :). I will just wait till you feel it is ready and review selected files, then merge it and test on-line if all is OK. |
Ok, so the reason I marked this as WIP is that I was thinking about unconditionally adding the JS in Documenter.jl, but I think this approach is better because it allows us to statically insert these |
@nalimilan - I have checked it manually and it looks good (admittedly I have not checked all 1064 files, but a random sample looks OK). Do you want to check it additionally somehow? This is a structure of the folders after this PR:
and it is the same as
|
I trust you that it's OK. ;-) In the future, will it be necessary to apply these changes after each new release? Or is Documenter supposed to handle this? |
This is a good point. @pfitzseb - we probably need some script that would handle this after the release. Right?
Thank you! |
Ok, so I read up on SEO a bit more today and apparently modern search engines can handle dynamic meta tags just fine, so my current thinking is to get a PR to Documenter done that automatically displays the warning for future old versions. Let's hold off on merging this PR in the meantime, although I don't really anticipate any significant changes. |
OK - waiting for the update then. Thank you! |
2aa8aaf
to
15f878a
Compare
Why is this closed? |
Because I force pushed (what I thought is) a new commit without ever actually creating that commit. |
4628c2e
to
1545457
Compare
But should we merge this PR now, or wait for the Documenter.jl changes? |
Yeah good question. I'd probably wait until those PRs are merged. And no, nothing will happen automatically for old versions. It's (will be) as easy as |
OK - let us wait then. Can you please bump this PR when you feel it is ready to be merged. Thank you! |
@pfitzseb - what is the status here? (no rush, but I do not want to wait too long with the decision as then everyone will forget the status - thank you!) |
1545457
to
761a2da
Compare
Uhm, good question. I think this should be good to go now; I've updated this PR with the output of We'll need one more run before a new Documenter version is released that automatically adds the warning though. |
In summary (just to double check) - merging this now should be OK? |
Yeah, I don't anticipate any more (breaking) changes to either of those Documenter PRs. |
I am merging it then. I will review later how it looks like on production. @nalimilan @pfitzseb - also could you please have a look then to make sure that all is OK? Thank you! |
Had a quick look through the various versions and everything looks fine to me. |
I also checked and all looks good. Thank you! |
This adds a notice to all old docs pointing visitors to
/stable
as well as a<meta content="noindex" name="robots"/>
annotation to stop search engines from showing the page.Diff was generated with https://gist.github.com/pfitzseb/4b910449e21b51fed4b4a2a7c20912ff.
Edit: The diff is huge and does stuff like replacing
"
with"
, but all of that should be perfectly safe.