make sort kwarg in groupby more flexible #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nalimilan - this PR should be good for review. @pdeffebach - you might want to have a look at it in the context of DataFramesMeta.jl. Thank you! |
nalimilan
reviewed
Jul 23, 2021
nalimilan
approved these changes
Jul 23, 2021
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
|
Thank you! |
bkamins
added a commit
that referenced
this pull request
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2762.
If we accept it then:
sort=falseexplicitly then groups are created in order of appearancesort=truethen groups are sortedIf we agree to add this extension I will add tests and NEWS.md entry and finalize this PR.