Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make DataFrame constructor more flexible #2859

Merged
merged 5 commits into from
Sep 7, 2021
Merged

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Sep 5, 2021

Fixes #2858

@bkamins bkamins requested a review from nalimilan September 5, 2021 21:57
@bkamins bkamins added the feature label Sep 5, 2021
@bkamins bkamins added this to the 1.3 milestone Sep 5, 2021
@bkamins
Copy link
Member Author

bkamins commented Sep 5, 2021

As usual with dispatch it is more tricky than it seems, but I hope all is good 😄.

@bkamins
Copy link
Member Author

bkamins commented Sep 6, 2021

The CI failure is Out of Memory error - re-triggering just to make sure all is OK.

@bkamins
Copy link
Member Author

bkamins commented Sep 6, 2021

@nalimilan - I have added the copycols kwarg support for matrix constructor. Can you please re-review the PR? Thank you!

src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
test/constructors.jl Outdated Show resolved Hide resolved
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
@bkamins
Copy link
Member Author

bkamins commented Sep 6, 2021

OK to merge after CI passes?

@bkamins bkamins merged commit 1a6fd15 into main Sep 7, 2021
@bkamins bkamins deleted the bk/more_flexible_constructor branch September 7, 2021 05:30
@bkamins
Copy link
Member Author

bkamins commented Sep 7, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants