-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate precompile statements for Julia 1.7 #2955
Conversation
Compilation time of 1.3 release (first timing is with precompilation):
vs 1.2.2 (first timing is with precompilation):
(and I think it is worth to reduce the |
You mean that statements that are only used when |
I have run the test on DataFrames 1.2.2. With
and now manually in DataFrames 1.2.2 I removed these statements:
(these are times of first run including pre-compilation) |
After precompilation the relevant thing is number of allocations (as timings are naturally somewhat variable). In 1.2.2 with removed
and when keeping these statements:
so it is a bit better to remove them (not much but bettet) |
I have run more tests and the difference in compilation time after first precompilation is very small, so it can be ignored. Still I would also prefer to reduce precompilation time + not have so much code in the package that is not used. |
OK. I guess we'll see whether H2Oai or another benchmark would benefit from adding more precompile statements in the future. |
Thank you! |
Fixes #2921
@nalimilan - I have removed the extra precompile statements for
all=true
to reduce the size of the code parsed (it slightly reduces the load time) and since it was only used in H2O tests which are dead now (I have retained some minimal things that are done whenall=true
but they are minor).