Code

Improve performance of dropmissing#3256

Code

Merged

bkamins merged 41 commits intoJuliaData:mainJuliaData/DataFrames.jl:mainfrom svilupp:improve-dropmissing-perfsvilupp/DataFrames.jl:improve-dropmissing-perfCopy head branch name to clipboardJan 27, 2023

+84-2

Commits

Commits on Dec 23, 2022

• init

  svilupp

  committed
  940c1cd

Commits on Jan 14, 2023

• Merge remote-tracking branch 'upstream/main' into improve-dropmissing-perf

  svilupp

  committed
  e3ae2b0

• add dropmissing8 implementation

  svilupp

  committed
  472a715

Commits on Jan 15, 2023

• Update src/other/utils.jl

  Show description for 7b5e010
  

  svilupp

  and

  bkamins

  authored
  7b5e010

• move last_ind to separate line, add inbounds

  svilupp

  committed
  dc705e8

• support general vectors in getindex_disallowmissing

  Show description for f52ed41
  svilupp

  committed
  f52ed41

• add general fallback for getindex_disallowmissing

  svilupp

  committed
  72171c9

• method for getindex_disallowmissing for abstractdataframe

  svilupp

  committed
  4a596ee

Commits on Jan 21, 2023

• changed inner to disallowmissing+view

  svilupp

  committed
  6326f32

• Clean up

  Show description for 080c018
  svilupp

  committed
  080c018

Commits on Jan 22, 2023

• updated comments

  svilupp

  committed
  a0bf440

• update view format

  svilupp

  committed
  dcfa4e1

• Change back to @view, due to errors with view()

  svilupp

  committed
  9b4478f

• import view() explicitly

  svilupp

  committed
  afef173

• add note on dropmissing parallelism

  Show description for fc643bb
  svilupp

  committed
  fc643bb

• added test for zero-column and CategoricalArrays

  svilupp

  committed
  d8248a4

• added test for view=true in dropmissing

  svilupp

  committed
  b63ee37

• add case for dropmissing!

  svilupp

  committed
  bd343a3

• add disallowmissing=false test

  svilupp

  committed
  16c278d

• removed duplicative test case

  svilupp

  committed
  eb998cd

• add test case that disallowmissing=true targets only the required column

  svilupp

  committed
  20526dd

• simplified the docstring

  svilupp

  committed
  13deb84

• Update docs/src/lib/functions.md

  Show description for fdc8e60
  

  svilupp

  and

  nalimilan

  authored
  fdc8e60

• Update test/data.jl

  Show description for 504e4cd
  

  svilupp

  and

  nalimilan

  authored
  504e4cd

• Update src/abstractdataframe/abstractdataframe.jl

  Show description for c004a91
  

  svilupp

  and

  nalimilan

  authored
  c004a91

• Update src/abstractdataframe/abstractdataframe.jl

  Show description for b895692
  

  svilupp

  and

  nalimilan

  authored
  b895692

• Update src/other/utils.jl

  Show description for ba2760a
  

  svilupp

  and

  nalimilan

  authored
  ba2760a

• Update test/data.jl

  Show description for d0f1187
  

  svilupp

  and

  nalimilan

  authored
  d0f1187

• Update test/data.jl

  Show description for 8c51985
  

  svilupp

  and

  nalimilan

  authored
  8c51985

• Update test/data.jl

  Show description for 267e566
  

  svilupp

  and

  nalimilan

  authored
  267e566

Commits on Jan 23, 2023

• use @spawn_or_run to avoid duplication

  svilupp

  committed
  94b091a

• add test for multithreaded path

  svilupp

  committed
  fa288f6

• Reduced test case memory requirement

  svilupp

  committed
  5172e72

Commits on Jan 24, 2023

• Apply suggestions from code review

  bkamins

  authored
  301bdea

• Update src/abstractdataframe/abstractdataframe.jl

  bkamins

  authored
  c6477bf

• Apply suggestions from code review

  bkamins

  authored
  3d82b90

• Apply suggestions from code review

  bkamins

  authored
  f26c99a

• Update test/data.jl

  bkamins

  authored
  fffda53

• Update test/data.jl

  bkamins

  authored
  82f193c

Commits on Jan 26, 2023

• Apply suggestions from code review

  bkamins

  authored
  1426e3a

Commits on Jan 27, 2023

• Apply suggestions from code review

  Show description for 39580a2
  

  bkamins

  and

  nalimilan

  authored
  39580a2