add keep to nonunique, unique, and unique! #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @jariji (naming of new argument) |
|
LGTM |
|
@nalimilan - in the PR I also improve performance of deduplicating in case we deduplicate columns that have refpools. Unfortunately this means that the PR gets a bit more complex now. |
nalimilan
reviewed
Jan 8, 2023
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
nalimilan
reviewed
Jan 23, 2023
nalimilan
reviewed
Jan 27, 2023
nalimilan
approved these changes
Jan 27, 2023
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
bkamins
commented
Jan 28, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2443
Additionally
row_group_slotsis renamed torow_group_slots!because it modifies one of its arguments.