Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in fast aggregation of missing only columns for sum and mean #3268

Merged
merged 4 commits into from
Jan 11, 2023
Merged

Fix error in fast aggregation of missing only columns for sum and mean #3268

merged 4 commits into from
Jan 11, 2023

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Jan 10, 2023

Fixes #3267

@bkamins bkamins requested a review from nalimilan January 10, 2023 23:26
@bkamins bkamins added the bug label Jan 10, 2023
@bkamins bkamins added this to the 1.5 milestone Jan 10, 2023
@bkamins bkamins mentioned this pull request Jan 10, 2023
Closed
nalimilan
nalimilan approved these changes Jan 11, 2023
View reviewed changes
test/select.jl Outdated Show resolved Hide resolved
@bkamins bkamins merged commit 81f1871 into main Jan 11, 2023
@bkamins bkamins deleted the bk/selectionfast branch January 11, 2023 15:31
@bkamins
Copy link
Member Author

bkamins commented Jan 11, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

sum doesn't work with Missing column
2 participants
@bkamins @nalimilan