Skip to content
This repository has been archived by the owner on May 5, 2019. It is now read-only.

Remove unused functions and increase test coverage #31

Merged
merged 4 commits into from
May 12, 2017
Merged

Remove unused functions and increase test coverage #31

merged 4 commits into from
May 12, 2017

Conversation

cjprybol
Copy link
Contributor

@cjprybol cjprybol commented Mar 10, 2017

No description provided.


@testset "misc" begin
dt = DataTable(A = 'A':'C')
@test sprint(dump, dt) == "DataTables.DataTable 3 observations of 1 variables\n A: Array{Char}((3,))\n 1: Char A\n 2: Char B\n 3: Char C\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use triple quotes for this kind of multiline string:

"""DataTables.DataTable  3 observations of 1 variables
  A: Array{Char}((3,))
    1: Char A
    2: Char B
    3: Char C
"""

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The leading newline is chomped out I believe, so I think you can add a line break between """ and D.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it took me some time to get it right, but this one should work. OTOH leading spaces are removed when they align with the quotes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, TIL.

@cjprybol cjprybol changed the title Tests, fixes, and functions that were missed for removal in my prior PRs Remove unused functions and increase test coverage Mar 31, 2017
@cjprybol
Copy link
Contributor Author

cjprybol commented Apr 4, 2017

I've redone the commits here to be 4 logical units.

@nalimilan nalimilan closed this May 12, 2017
@nalimilan nalimilan reopened this May 12, 2017
@nalimilan nalimilan merged commit defbf7b into JuliaData:master May 12, 2017
@cjprybol cjprybol deleted the cjp/miscfixes branch May 13, 2017 19:30
@cjprybol
Copy link
Contributor Author

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants