Add allowmissing() and disallowmissing() convenience functions #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As requested by several people, given that the convert() call is complex and not easy to discover.
cjprybol
approved these changes
Dec 4, 2017
cjprybol
reviewed
Dec 5, 2017
|
|
||
| See also: [`disallowmissing`](@ref) | ||
| """ | ||
| allowmissing(x::AbstractVector{T}) where {T} = convert(AbstractArray{Union{T, Missing}}, x) |
There was a problem hiding this comment.
Oops. Didn't catch this until after I merged. I think these are supposed to be x::AbstractArray as shown in the docstring. I'll open a PR with a fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by several people, given that the convert() call is complex
and not easy to discover.
Fixes #60.