Use Base.Missing on Julia 0.7 #68
Conversation
| using Compat | ||
|
|
||
| export allowmissing, disallowmissing, ismissing, missing, missings, | ||
| Missing, MissingException, levels, skipmissing | ||
|
|
||
| """ | ||
| Missing | ||
| if VERSION < v"0.7.0-DEV.2762" |
There was a problem hiding this comment.
It's kind of weird, but if I define the types in the same if block as the rest I get type definition not allowed inside a local scope errors.
There was a problem hiding this comment.
That's really bizarre. What if you put an @static annotation on the if?
There was a problem hiding this comment.
Same. AFAIK @static has no effect at the top level. I've found this issue, but it's pretty old and apparently closed: JuliaLang/julia#10555
EDIT: actually it's not closed, it's just a dup. Probably related to the presence of a for loop.
There was a problem hiding this comment.
@static is used at the top level in Compat.jl: https://github.com/JuliaLang/Compat.jl/blob/master/src/Compat.jl
There was a problem hiding this comment.
Yes, but I can swear that I've read a comment by Jameson saying that has no effect.
There was a problem hiding this comment.
I used it to hide old deprecated syntax from 0.7: https://github.com/JuliaLang/Compat.jl/pull/419/files
There was a problem hiding this comment.
My understanding is that since the condition is evaluated at parse time, it gives an opportunity to trick the parser into ignoring things doesn't particularly like.
|
I guess so. However it's not clear whether we'll be able to move everything to Base. For example I'm not sure |
Adapt to JuliaLang/julia#24653. Tests still fail on 0.7 due to a
promote_typebug in Julia, but most features work.