Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete extension of ipermute!! #9

Closed
wants to merge 1 commit into from

Conversation

kafisatz
Copy link

@kafisatz kafisatz commented Jun 8, 2018

ipermute!! does not seem to exist in v 0.7

ipermute!! does not seem to exist in  v 0.7
@kafisatz kafisatz mentioned this pull request Jun 8, 2018
@swt30
Copy link

swt30 commented Jun 11, 2018

ipermute and related methods are called invpermute in 0.7 (see JuliaLang/julia#25168).

@kafisatz
Copy link
Author

indeed. I will close this.

@kafisatz kafisatz closed this Jun 11, 2018
@swt30
Copy link

swt30 commented Jun 11, 2018

I think the best thing to do is to wait for femtocleaner to be ready for 0.7, which should be very soon. Then changes like this can all be done at once :)

@kafisatz
Copy link
Author

@swt30 Funny that you should mention that. I am actually trying to get FemtoCleaner working LOCALLY on either 0.6.3 or 0.7alpha. I am failing at both, although I thought that it would at least work on 0.6.3 somehow.

@swt30
Copy link

swt30 commented Jun 28, 2018

@kafisatz My fork has a branch updated to remove deprecation warnings so that this works on julia 0.7. You can try it by doing add https://github.com/swt30/PooledArrays.jl.git#julia-0.7 at the pkg prompt if you like.

@kafisatz
Copy link
Author

Thank you

@swt30
Copy link

swt30 commented Jul 3, 2018

A new tag was just merged here with 0.7 support so I'm deleting that fork and switching back to this repo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants