WeakRefStringArray: allow only WeakRefString elems

JuliaData · Dec 20, 2017 · 092d943 · 092d943
1 parent 45d595d
commit 092d943
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/WeakRefStrings.jl b/src/WeakRefStrings.jl
@@ -75,7 +75,7 @@ Base.convert(::Type{String}, x::WeakRefString) = convert(String, string(x))
 Base.String(x::WeakRefString) = string(x)
 Base.Symbol(x::WeakRefString{UInt8}) = ccall(:jl_symbol_n, Ref{Symbol}, (Ptr{UInt8}, Int), x.ptr, x.len)
 
-struct WeakRefStringArray{T, N, U} <: AbstractArray{Union{String, U}, N}
+struct WeakRefStringArray{T<:WeakRefString, N, U} <: AbstractArray{Union{String, U}, N}
     data::Vector{Any}
     elements::Array{Union{T, U}, N}
 

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -91,4 +91,12 @@ end
     E = WeakRefStringArray(data, [str missing])
     @test size(E) == (1, 2)
     @test eltype(E) === Union{String, Missing}
+
+    # WeakRefStringArray only supports WeakRefString elements
+    @test_throws MethodError WeakRefStringArray(UInt8[], String, 0)
+    @test_throws MethodError WeakRefStringArray(UInt8[], Int, 0)
+    @test_throws MethodError WeakRefStringArray(UInt8[], Union{String, Missing}, 0)
+    @test_throws MethodError WeakRefStringArray(UInt8[], Union{Int, Missing}, 0)
+    @test_throws MethodError WeakRefStringArray(UInt8[], [1, 2])
+    @test_throws MethodError WeakRefStringArray(UInt8[], [1.0, missing])
 end