-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add More tests #101
Add More tests #101
Conversation
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 81.32% 82.75% +1.42%
==========================================
Files 12 12
Lines 1462 1461 -1
==========================================
+ Hits 1189 1209 +20
+ Misses 273 252 -21
Continue to review full report at Codecov.
|
Ok, so I am glad it wasn't my multi-constructor code from earlier. But I am confused on why running |
efe4d32
to
cebbd27
Compare
Thanks for digging into it! Definitely weird - here's the first bit of the stacktrace (I'm sure you've seen it, just pulling it out for others)
Have you pulled out and looked at what |
cebbd27
to
0f5fc73
Compare
@kescobo So after putting in debug statements and trying some data massaging, the |
Windows often uses different line endings ( |
Chomp the strings for testing
53d4e54
to
e58bcc1
Compare
Chomped the strings. Everything passes. Yay! 😁 |
Thank you! I'll try to review and merge tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me - I'll open an issue about this line ending problem - should be possible to do platform-dependent tests so that we don't have to chomp line endings, but this is good for now I think
Adds tests for the additional load functions.
Contains commits from #100