Fix Julia 1.0 support #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Appears that the Travis CI integration also needs to be disabled for this project. |
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
=======================================
Coverage 83.82% 83.82%
=======================================
Files 12 12
Lines 1478 1478
=======================================
Hits 1239 1239
Misses 239 239
Continue to review full report at Codecov.
|
fchorney
approved these changes
Jan 20, 2021
nicoleepp
approved these changes
Jan 20, 2021
christopher-dG
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isnothingfunction isn't defined on Julia 1.0. The CI unfortunately wasn't testing against Julia 1.0 as using the number1.0in GitHub actions resolves to the latest version of Julia 1 (1.0→1→1.5.3) where as using the string"1.0"works as expected ("1.0"→"1.0.5").