Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison with nothing to use idetity checking #159

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

Paalon
Copy link
Contributor

@Paalon Paalon commented Jun 11, 2024

Comparison with nothing should use identity checking operators like === or !==.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.23%. Comparing base (844ad27) to head (d69529b).
Report is 5 commits behind head on master.

Files Patch % Lines
src/composer.jl 0.00% 1 Missing ⚠️
src/constructor.jl 0.00% 1 Missing ⚠️
src/parser.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
- Coverage   86.59%   86.23%   -0.37%     
==========================================
  Files          12       12              
  Lines        1626     1627       +1     
==========================================
- Hits         1408     1403       -5     
- Misses        218      224       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Paalon
Copy link
Contributor Author

Paalon commented Jun 12, 2024

If we can drop support for Julia v1.0, we should use isnothing for comparing nothing.

Copy link
Collaborator

@kescobo kescobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to this, these are equivalent? But I think this is more idiomatic

@kescobo kescobo merged commit 8180df4 into JuliaData:master Jun 12, 2024
20 of 31 checks passed
@Paalon Paalon deleted the fix-nothing-comparison branch June 12, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants