Refactoring by using isa
#161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is better in terms of performance.
Paalon
added a commit
to Paalon/YAML.jl
that referenced
this pull request
Jun 12, 2024
`peek(stream.input)` is a token instance, so it should be `in(typeof(peek(stream.input)), [A, B, C, D]`. However, it is better to use `isa` and `Union`, as I mentioned in JuliaData#161.
kescobo
approved these changes
Jun 12, 2024
kescobo
added a commit
that referenced
this pull request
Jun 12, 2024
* Fix a bug in `parse_document_content`. `peek(stream.input)` is a token instance, so it should be `in(typeof(peek(stream.input)), [A, B, C, D]`. However, it is better to use `isa` and `Union`, as I mentioned in #161. * Update src/parser.jl Co-authored-by: Kevin Bonham <kevbonham@gmail.com> * Add a test. --------- Co-authored-by: Kevin Bonham <kevbonham@gmail.com>
|
For what it's worth, Regardless I fully agree with changing all of this to |
Indeed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change direct comparisons of types
typeof(x) == ConcreteTypeto usingx isa ConcreteType. Especially,isa(x, Union{A, B, C})is better thanin(typeof(x), [A, B, C])in terms of performance.