Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of scan_yaml_directive_number #191

Merged
merged 1 commit into from
Jun 16, 2024
Merged

Refactoring of scan_yaml_directive_number #191

merged 1 commit into from
Jun 16, 2024

Conversation

Paalon
Copy link
Contributor

@Paalon Paalon commented Jun 15, 2024

Refactoring of scan_yaml_directive_number.

  • Add many comments.
  • Easy control flow.

@Paalon
Refactoring of scan_yaml_directive_number.
7df5923 
* Add many comments.
* Easy control flow.
kescobo
kescobo approved these changes Jun 16, 2024
View reviewed changes
Copy link
Collaborator

@kescobo kescobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The # ---- lines seem a little much to me, but not enough to ask for them to change.

@kescobo kescobo merged commit a83f3b4 into JuliaData:master Jun 16, 2024
20 checks passed
@Paalon Paalon deleted the scan_yaml_directive_number branch June 16, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kescobo kescobo kescobo approved these changes

@GunnarFarneback GunnarFarneback GunnarFarneback approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Paalon @GunnarFarneback @kescobo