Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated badges #67

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Remove outdated badges #67

merged 1 commit into from
Dec 11, 2020

Conversation

mlhetland
Copy link
Contributor

Remove SVG badges that no longer exist. They could be replaced, but in their current form, they simply don't work.

@codecov
Copy link

codecov bot commented Sep 28, 2019

Codecov Report

Merging #67 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   79.49%   79.49%           
=======================================
  Files          12       12           
  Lines        1341     1341           
=======================================
  Hits         1066     1066           
  Misses        275      275           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bf20c6...4f988a8. Read the comment docs.

@kescobo
Copy link
Collaborator

kescobo commented Aug 27, 2020

Sorry for letting this languish - any chance you'd be willing to update / rebase?

@kescobo kescobo added the bug label Aug 27, 2020
@kescobo kescobo self-requested a review August 27, 2020 13:38
@mlhetland
Copy link
Contributor Author

Did that work?-)

@mirkobunse
Copy link
Contributor

The diff looks perfect, but why does the PR show 15 commits?

@mlhetland
Copy link
Contributor Author

Uh. I probably messed up rebase/merge, somehow? Dunno. Feel free to scrap the PR and just do the edit directly!-D It's entirely trivial, after all.

@kescobo
Copy link
Collaborator

kescobo commented Aug 27, 2020

I think this is a merge with all of the intervening commits. @mlhetland I'd suggest the following - on your open branch:

$ cp README.md ~/Desktop
$ git remote add upstream https://github.com/JuliaData/YAML.jl.git # assuming you haven't done this already
$ git reset --hard upstream master # this is a destructive operation
$ mv ~/Desktop/README.md ./
$ git commit -am "Remove outdated badges"
$ git push -f # force overwrite

This is kinda a manual rebase, since you've only changed one file. Alternatively, I'm happy to do it manually if you don't want to bother :-)

Copy link
Contributor

@christopher-dG christopher-dG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably merge this now.

@kescobo kescobo merged commit c124969 into JuliaData:master Dec 11, 2020
@mlhetland mlhetland deleted the patch-2 branch December 12, 2020 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants