Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print empty dicts as {} and lists as [] #96

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Print empty dicts as {} and lists as [] #96

merged 2 commits into from
Jan 20, 2021

Conversation

christopher-dG
Copy link
Contributor

@christopher-dG christopher-dG commented Dec 10, 2020

This makes empty dicts and lists properly round-trip-able.

@christopher-dG christopher-dG changed the title Print empty dicts as {} Print empty dicts as {} and lists as [] Dec 11, 2020
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #96 (bf1345e) into master (86e6ca6) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   83.82%   83.70%   -0.13%     
==========================================
  Files          12       12              
  Lines        1478     1479       +1     
==========================================
- Hits         1239     1238       -1     
- Misses        239      241       +2     
Impacted Files Coverage Δ
src/writer.jl 98.07% <100.00%> (+0.03%) ⬆️
src/parser.jl 75.22% <0.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86e6ca6...bf1345e. Read the comment docs.

Copy link
Collaborator

@kescobo kescobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - anything outstanding?

@christopher-dG
Copy link
Contributor Author

Don't think so. It'll have a small conflict with #95 (test cases added in the same place) but an easy fix.

@christopher-dG christopher-dG merged commit 31f1911 into JuliaData:master Jan 20, 2021
@christopher-dG christopher-dG deleted the cdg/emptydict branch January 20, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants