Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized save #347

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Generalized save #347

wants to merge 1 commit into from

Conversation

Qfl3x
Copy link
Contributor

@Qfl3x Qfl3x commented Oct 19, 2023

#309

Still needs some docs

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.61%. Comparing base (ee64a86) to head (8aa1edc).
Report is 138 commits behind head on master.

Files with missing lines Patch % Lines
src/DatasetAPI/Datasets.jl 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
- Coverage   69.74%   69.61%   -0.13%     
==========================================
  Files          12       12              
  Lines        1702     1774      +72     
==========================================
+ Hits         1187     1235      +48     
- Misses        515      539      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lazarusA
Copy link
Collaborator

more importantly doc strings and tests 😄 . But, I would like to have the opinion of @meggart on this?

@lazarusA lazarusA requested a review from meggart October 19, 2023 09:42
Copy link
Member

@meggart meggart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, yes its a good idea to merge the 2. However, it would be good to be consequent and just deprecate savecube and savedataset (see the docs of the @deprecate macro) so that we can entirely remove them in future YAXArray versions.

@lazarusA lazarusA added the help wanted Extra attention is needed label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants