Add asynchronous execution #109
Conversation
|
(deleted the duplicate submissions) |
Co-Authored-By: Lyndon White <oxinabox@ucc.asn.au>
| end | ||
| end | ||
|
|
||
| iserror(async_result::AsyncResult) = Base.istaskfailed(async_result.result_task) |
There was a problem hiding this comment.
Do we need to open an upstream issue to get this exported?
There was a problem hiding this comment.
Co-Authored-By: Lyndon White <oxinabox@ucc.asn.au>
Co-Authored-By: Lyndon White <oxinabox@ucc.asn.au>
| Base.islocked(conn::Connection) = islocked(conn.lock) | ||
| Base.lock(conn::Connection) = acquire(conn.semaphore) | ||
| Base.unlock(conn::Connection) = release(conn.semaphore) | ||
| Base.islocked(conn::Connection) = conn.semaphore.curr_cnt >= conn.semaphore.sem_size |
There was a problem hiding this comment.
We should raise an issue up stream that semaphore does not implement islocked
There was a problem hiding this comment.
| finally | ||
| unlock(conn) | ||
| end | ||
| end |
There was a problem hiding this comment.
why did yo unroll this rather than using lock(f, conn.lock)?
Is it because Semaphore's don't implement that pattern?
if so we should open an issue about it
There was a problem hiding this comment.
Also, lock(f, the_lock) is restricted to ::AbstractLock, even though It probably shouldn't be. I mentioned that one a draft PR I made that no one looked at.
There was a problem hiding this comment.
|
Do |
|
|
|
Ok, I am now in-principle happy with this PR. |
Adds support for asynchronous execution using https://www.postgresql.org/docs/10/libpq-async.html
TODO:
task.sticky = false@par, will wait another release to be sure it's not a bad interaction with the uv event loop