Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add boundserror when indexing into an invalid column #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add boundserror when indexing into an invalid column #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/results.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,7 @@ The returned value will be `missing` if `NULL`, or will be of the type specified
[`column_types`](@ref).
"""
function Base.getindex(jl_result::Result, row::Integer, col::Integer)
if isnull(jl_result, row, col)
if isnull(jl_result, row, column_number(jl_result, col))
return missing
else
oid = column_oids(jl_result)[col]
Expand Down
1 change: 1 addition & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,7 @@ end
@test data[1][2] == "bar"
@test data[2].yes_nulls === missing
@test data[2][2] === missing
@test_throws BoundsError data[1].fake_column

# columns
ct = Tables.columns(result)
Expand Down