Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of MySQLDate and MySQLDateTime types #28

Merged
merged 3 commits into from
Nov 30, 2015

Conversation

nkottary
Copy link
Member

Related to #27

  • Removed MySQLDate and MySQLDateTime types. Using Date and DateTime types from Dates module instead.
  • Modified tests for the same.
  • Contains fix for Problem parsing SQL Timestamps #26

@@ -1,5 +1,7 @@
# Constructors for the julia Date, Time and DateTime types.

using Dates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if VERSION < v"0.4-"
using Dates
else
using Base.Dates
end

@nkottary
Copy link
Member Author

Can this be merged now ?

nkottary added a commit that referenced this pull request Nov 30, 2015
Use Date and DateTime from Base.Dates instead of MySQLDate, MySQLTime and MySQLDateTime types
@nkottary nkottary merged commit 21c1ebb into JuliaDatabases:master Nov 30, 2015
@nkottary nkottary mentioned this pull request Nov 30, 2015
@nkottary nkottary deleted the nk-use-dates branch November 30, 2015 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants