a collection of changes while locally testing SQLite (and CSV, DataStreams) #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi SQLite.jl-ers,
when trying to parse a CSV into SQLite using the jq/updates branch, several problems emerged, at least, on my release-0.4 julia. having fixed most of them, the SQLite package now passes the tests for me.
this pull request is a collection of small changes (or can be viewed as one large diff), which adds some code (to the runtests mainly and close functions for SQLite types), refactors a bit (move serialize to separate file) and even fixes a bug or two (parsing @ parameter names from sqlite3).
hope this helps the maturation of the package.