New DataStreams framework implementation for SQLite.jl #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,54 +65,75 @@ function SQLiteDB(file::AbstractString="";UTF16::Bool=false) | |||
| else # error | |||
| sqlite3_close(handle[1]) | |||
| sqliteerror() | |||
| >>>>>>> d86fcf628105a178ae6fc0128740e4ec2df8b2e7 | |||
There was a problem hiding this comment.
Merge conflict, I think you meant to remove this function?
There was a problem hiding this comment.
drat. i think things got borked somehow. I'll do a clean force push
|
I've given it a quick once over but I'm not gonna have time to play with it properly until the weekend. Looking good though! |
|
Thanks for the review so far. I cleaned up the git history quite a bit and just decided to open a new PR at #80. I'll keep this up through this weekend. I'll probably plan on merging and tagging sometime this weekend (along with a nice blog post mentioned some of the higher-level changes). |
| sqlitetype{T<:Integer}(::Type{T}) = SQLITE_INTEGER | ||
| sqlitetype{T<:AbstractFloat}(::Type{T}) = SQLITE_FLOAT | ||
| sqlitetype{T<:AbstractString}(::Type{T}) = SQLITE_TEXT | ||
| sqlitetype(x) = SQLITE_BLOB |
There was a problem hiding this comment.
Does there also need to be a method for NullType here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Sean1708, it's finally ready :) (hopefully)
I still need to update the README, but I've put in the new 0.4 docs inline with the code. There's almost no change in the UDF functionality/usage. The core types/methods have been refactored slightly (
SQLiteDB=>SQLite.DB), plus slightly more idiomatic usage of the!operator.The biggest changes are in the removal of the
create/appendmethods (which I can't remember if they're even on master or were just onjq/updates). These have been replace by the more robust and broadly applicableDataStreamsframework by having theSQLite.SourceandSQLite.Sinktypes and the appropriateData.stream!methods defined between them andData.Table,CSV.Source, andCSV.Sink.I believe the deprecations have all been setup correctly, but I'd appreciate any poking around here. Basically, all the deprecated types/methods are in
old_ui.jland the old tests still exist attest/old_runtests.jl.